Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console error on feedback button #1560

Closed
wants to merge 3 commits into from
Closed

Fix console error on feedback button #1560

wants to merge 3 commits into from

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Mar 15, 2022

Overview

Fixes console error caused by feedback form rendering
image

ElinorW
ElinorW reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ElinorW ElinorW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if this is related but clicking on the button, now brings this warning
image

@Onokaev
Copy link
Contributor Author

Onokaev commented Mar 31, 2022

Don't know if this is related but clicking on the button, now brings this warning image

Looking into it

@Onokaev Onokaev marked this pull request as draft April 11, 2022 06:04
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1560.centralus.azurestaticapps.net

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Onokaev
Copy link
Contributor Author

Onokaev commented Jun 9, 2022

This has been resolved in the header PR: #1682

@Onokaev Onokaev closed this Jun 9, 2022
@thewahome thewahome deleted the fix/feedback-console-error branch February 28, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElinorW ElinorW ElinorW left review comments

@thewahome thewahome Awaiting requested review from thewahome

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@ddyett ddyett Awaiting requested review from ddyett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Onokaev @ElinorW