Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Varying response heights #2704

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Aug 1, 2023

Overview

Closes #2703

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
    Click on the Response tabs
    Notice that the heights remain consistent through the different tabs
    Zoom in and out to get into mobile screen. Notice that the app is still responsive

@Onokaev Onokaev requested a review from a team as a code owner August 1, 2023 13:20
@Onokaev Onokaev changed the title Fix/varying response heights Fix: Varying response heights Aug 1, 2023
@Onokaev Onokaev changed the title Fix: Varying response heights Enhancement: Varying response heights Aug 1, 2023
@ElinorW
Copy link
Contributor

ElinorW commented Aug 3, 2023

Hey @Onokaev
This is great! The responses are definitely not jumping around anymore...
I think you may need to adjust the monaco height, seems like some code is getting chopped off
image

ElinorW
ElinorW previously approved these changes Aug 8, 2023
@Onokaev Onokaev merged commit 3a37c81 into dev Aug 8, 2023
@Onokaev Onokaev deleted the fix/varying-response-heights branch August 8, 2023 13:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on different response tabs causes the app to resize differently
2 participants