Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add required header for tip annotations display #2726

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Fix: Add required header for tip annotations display #2726

merged 3 commits into from
Aug 8, 2023

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Aug 3, 2023

Overview

Fixes #2636

Demo

image

Notes

  • Works for signed-in users
  • Doesn't affect queries with no tip message

Testing Instructions

  • Check out this branch and load Graph Explorer locally
  • Sign in with the preferred account
  • Run /users query
  • Observe tip message

@ElinorW ElinorW requested a review from a team as a code owner August 3, 2023 12:59
@Onokaev
Copy link
Contributor

Onokaev commented Aug 3, 2023 •
edited
Loading

Remember to ask the portals team to add the new header to their API calls to Graph on the proxy service.

@ElinorW ElinorW merged commit 9c6b6f8 into dev Aug 8, 2023
@ElinorW ElinorW deleted the feature/add-select-tip branch August 8, 2023 11:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

This was referenced Sep 25, 2024
Closed
Closed
Merged
@release-please release-please bot mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Onokaev Onokaev Onokaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encourage callers to use $select and inform callers when there's default properties in the response
2 participants
@ElinorW @Onokaev