Fix: Add 'Maximize sidebar' aria-label #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewahome
approved these changes
Feb 11, 2021
ElinorW
added a commit
that referenced
this pull request
Feb 16, 2021
* Fix: support different content types (#814) * Feature: Add Adaptive cards JSON Schema code (#828) * Feature: samples testing (#833) * Feature: Adds 'Report an Issue' menu option (#834) * Feature: clickable links on message bar (#835) * fix: intermittent create page error (#837) * Fix: Add 'Maximize sidebar' aria-label (#842) * Task: upgrade technologies (#844) * Fix: expand maxWidth allow more humanName chars (#764) * Fix: autocomplete options not displaying (#847) * fix: adaptive cards destroy (#848) * Fix: Graph Explorer link colors (#846) * Fix: Adaptive cards instrumentation (#849) * Fix: adjust column width (#850) * Task: prevent storing access token (#851) Co-authored-by: jobala <[email protected]> Co-authored-by: Charles Wahome <[email protected]> Co-authored-by: OfficeGlobal <[email protected]> Co-authored-by: OfficeGlobal <[email protected]> Co-authored-by: Azure Static Web Apps <[email protected]> Co-authored-by: Millicent Achieng <[email protected]> Co-authored-by: Sébastien Levert <[email protected]> Co-authored-by: Ezrqn Kemboi <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Joseph Ngugi <[email protected]> Co-authored-by: Maggie Kimani <[email protected]>
ElinorW
added a commit
that referenced
this pull request
Feb 22, 2021
* Fix: support different content types (#814) * Feature: Add Adaptive cards JSON Schema code (#828) * Feature: samples testing (#833) * Feature: Adds 'Report an Issue' menu option (#834) * Feature: clickable links on message bar (#835) * fix: intermittent create page error (#837) * HB of localized GE.jsons (#830) * Fix: Add 'Maximize sidebar' aria-label (#842) * Task: upgrade technologies (#844) * Fix: expand maxWidth allow more humanName chars (#764) * Fix: autocomplete options not displaying (#847) * fix: adaptive cards destroy (#848) * Fix: Graph Explorer link colors (#846) * Fix: Adaptive cards instrumentation (#849) * Fix: adjust column width (#850) * Task: prevent storing access token (#851) * HB of localized GE.jsons (#854) * chore(release): 4.3.0 (#857) * Fix: rename component name (#859) * chore(release): 4.4.0 Co-authored-by: jobala <[email protected]> Co-authored-by: Charles Wahome <[email protected]> Co-authored-by: OfficeGlobal <[email protected]> Co-authored-by: OfficeGlobal <[email protected]> Co-authored-by: Azure Static Web Apps <[email protected]> Co-authored-by: Millicent Achieng <[email protected]> Co-authored-by: Sébastien Levert <[email protected]> Co-authored-by: Ezrqn Kemboi <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Joseph Ngugi <[email protected]> Co-authored-by: Maggie Kimani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This add's the maximize sidebar aria-label to ensure accurate information is read by the screen reader.
It also ensures the tooltip message is changed from "minimize sidebar' to 'maximize sidebar' when the sidebar is minimized and vice versa when the sidebar is maximized.
Fixes #841
Screenshots
Tooltip view when sidebar is maximized
Tooltip view when sidebar is minimized
