-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAUI support #486
Merged
Merged
MAUI support #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 24, 2022
Passing handlers to GraphClientFactory.Create() creates a HttpClient that disposes the handlers
#373
Closed
Closed
andrueastman
requested review from
MIchaelMainer,
peombwa and
zengin
as code owners
August 24, 2022 15:00
baywet
approved these changes
Aug 24, 2022
@@ -177,7 +177,7 @@ private HttpResponseMessage GetResponseMessageFromJObject(JsonElement jResponseI | |||
/// <returns>A batch response content as <see cref="JsonDocument"/>.</returns> | |||
private async Task<JsonDocument> GetBatchResponseContentAsync() | |||
{ | |||
if (this.batchResponseMessage.Content == null) | |||
if (this.batchResponseMessage.Content == null || this.batchResponseMessage.Content.Headers.ContentLength == 0 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (this.batchResponseMessage.Content == null || this.batchResponseMessage.Content.Headers.ContentLength == 0 ) | |
if (this.batchResponseMessage.Content == null || !this.batchResponseMessage.Content.Headers.Any()) |
This was referenced Aug 26, 2022
Passing handlers to GraphClientFactory.Create() creates a HttpClient that disposes the handlers
#373
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Microsoft.Graph.Core.XamarinAndroid.Test
project as thenet6.0
target is sufficient to close Can we get a .sln file that doesn't require the Xamarin SDK installed? #39net6.0
targetmsbuild
Microsoft Reviewers: Open in CodeFlow