Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes request content cloning exception in .NET 4.x #2209

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fixes request content cloning exception in .NET 4.x #2209

merged 3 commits into from
Aug 2, 2023

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Aug 1, 2023 •
edited
Loading

Fixes #2191

Changes proposed in this pull request

  • Changes log formatter's request cloning logic to try cloning the request content and skip if the content has already been disposed by the HttpClient. This behavior is only unique to VS Code extension running PowerShell 5.1 (.NET 4.x) and was fixed in .NET core+.

@peombwa peombwa marked this pull request as ready for review August 2, 2023 17:08
@peombwa peombwa requested a review from a team as a code owner August 2, 2023 17:08
@peombwa peombwa mentioned this pull request Aug 2, 2023
Closed
@peombwa peombwa requested a review from MIchaelMainer August 2, 2023 22:25
@peombwa peombwa self-assigned this Aug 2, 2023
@peombwa peombwa merged commit 6d50c8f into dev Aug 2, 2023
@peombwa peombwa deleted the bugfixes/HttpMessageClone branch August 2, 2023 23:17
@peombwa peombwa mentioned this pull request Aug 10, 2023
Merged
@bunderwood
Copy link

@peombwa thank you so much! This completely resolved my issue within VS Code. Such a relief.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

Assignees

@peombwa peombwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update-MgUser - Cannot access a disposed object System.Net.Http.StringContent
3 participants
@peombwa @bunderwood @MIchaelMainer