Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused poetry config to unblock Dependabot updates #719

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Dec 4, 2024

Some required parameters e.g. package name, version, authors for poetry's configuration are currently missing causing dependabot runs to fail for this repository causing older versions of dependencies to be used by customers.

We could add a complete poetry config to fix the issue, but we'd have duplicate config for versions, pkg name etc.
This PR proposes dropping the poetry config since we're not using poetry to manage dependencies, builds/releases.

Poetry required config ref

@Ndiritu Ndiritu self-assigned this Dec 4, 2024
@Ndiritu Ndiritu requested a review from a team as a code owner December 4, 2024 11:37
@Ndiritu Ndiritu changed the title chore: Removes unused poetry config to unblock Dependabot updates Removes unused poetry config to unblock Dependabot updates Dec 4, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any issues with removing poetry from the graph repos.
Simply wanted to point out the configuration is going to be different from the kiota python repo and there are benefits to aligning those things (streamlined tooling, etc...)

@Ndiritu
Copy link
Contributor Author

Ndiritu commented Dec 4, 2024

I don't have any issues with removing poetry from the graph repos. Simply wanted to point out the configuration is going to be different from the kiota python repo and there are benefits to aligning those things (streamlined tooling, etc...)

Definitely. Creating a new issue to track this. Disabling is a temporary measure to unblock kiota fixes getting to the SDK release & and dependabot upgrades.

@Ndiritu
Copy link
Contributor Author

Ndiritu commented Dec 4, 2024

Tracking here microsoftgraph/msgraph-sdk-python#969

@Ndiritu Ndiritu merged commit 8c3781a into main Dec 4, 2024
14 checks passed
@Ndiritu Ndiritu deleted the fix/dependabot-not-running branch December 4, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:security Security, or privacy issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants