Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommonJS export in version 3.2.1 #890

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fix CommonJS export in version 3.2.1 #890

merged 1 commit into from
Aug 23, 2022

Conversation

dnicolson
Copy link
Contributor

@dnicolson dnicolson commented Aug 23, 2022 •
edited
Loading

This pull request fixes the CommonJS export in version 3.2.1 due to a change in https://github.com/swc-project/swc/releases/tag/v1.2.206 (swc-project/swc#5204)

Version 3.2.1:

Object.defineProperty(module, "exports", {
    enumerable: true,
    get: ()=>_default
});

Version 3.2.0:

module.exports = _default;

@dnicolson dnicolson changed the title Fix CommonJS import in version 3.2.1 Fix CommonJS export in version 3.2.1 Aug 23, 2022
@willfarrell willfarrell merged commit 33cc706 into middyjs:main Aug 23, 2022
@willfarrell
Copy link
Member

Thanks for catching this!

@willfarrell
Copy link
Member

I added to simple test to catch breaking build changes in the future.

@willfarrell willfarrell mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnicolson @willfarrell