Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(4.0): resolve type errors #923

Merged
merged 13 commits into from
Oct 13, 2022
Merged

fix(4.0): resolve type errors #923

merged 13 commits into from
Oct 13, 2022

Conversation

naorpeled
Copy link
Contributor

@naorpeled naorpeled commented Oct 13, 2022 •
edited
Loading

No description provided.

@naorpeled naorpeled changed the base branch from main to feature/4.0 October 13, 2022 18:25
@naorpeled naorpeled marked this pull request as draft October 13, 2022 18:25
@naorpeled naorpeled closed this Oct 13, 2022
@naorpeled naorpeled reopened this Oct 13, 2022
@naorpeled naorpeled marked this pull request as ready for review October 13, 2022 20:31
@naorpeled
Copy link
Contributor Author

@willfarrell here you go :)

@willfarrell
Copy link
Member

Awesome, thanks. Note increasing the version was not necessary because this is a v4 branch.

@willfarrell willfarrell merged commit 9d16d34 into middyjs:feature/4.0 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naorpeled @willfarrell