Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest additions #376

Merged
merged 6 commits into from
Apr 24, 2012
Merged

Unittest additions #376

merged 6 commits into from
Apr 24, 2012

Conversation

lad1337
Copy link
Contributor

@lad1337 lad1337 commented Apr 20, 2012

added simple full pp test

and a yml for http://travis-ci.org/
you might want to add your repo to travis to

my one is at http://travis-ci.org/#!/lad1337/Sick-Beard

@thezoggy
Copy link
Contributor

we need to add docstrings to each test so we know what we are testing and what should be returned. like do we have a test that tries to load each provider? or notifiers? or metadata? and will it update automatically when new ones are added? what about our logger.. will it test that ? can we have it test logging rollover (set really low rollover limit / populate with fake data to force rollover) and then compare size? have it check connectivity to tvdb / providers / etc before running test? etc

@thezoggy
Copy link
Contributor

also run through pyflakes/pylint/pep8

midgetspy added a commit that referenced this pull request Apr 24, 2012
@midgetspy midgetspy merged commit f70c5d2 into midgetspy:development Apr 24, 2012
gborri pushed a commit to gborri/Sick-Beard that referenced this pull request Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants