Bugfix :: searchForNeededEpisodes : Fixed NoneType AttributeError exception. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased for current development branch. Been using for 2 months without issue. Haven't gotten around to checking findSeason() yet. |
| @@ -180,6 +180,11 @@ def searchForNeededEpisodes(): | |||
|
|
|||
| bestResult = pickBestResult(curFoundResults[curEp]) | |||
|
|
|||
| # if all results were rejected move on to the next episode | |||
| if not bestResult: | |||
| logger.log(u"All found results for %s were rejected." % curEp.prettyName(), logger.DEBUG) | |||
There was a problem hiding this comment.
Maybe edit this line to 'match' the rest?
logger.log(u"All found results for " + curEp.prettyName() + " were rejected.", logger.DEBUG)
There was a problem hiding this comment.
+1 for this addition. @Conjuro can you update so we can pull?
…eption. Don't store None value bestResult (occurs when all results are rejected) in foundResults list. Quality comparisons with results from other providers throws an exception.
|
Just got back from a week long out of town trip. As suggested by @itofzo, I've updated patch to use same style logging as rest of file. |
midgetspy
added a commit
that referenced
this pull request
Jul 9, 2013
Bugfix :: searchForNeededEpisodes : Fixed NoneType AttributeError exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't store None value bestResult (occurs when all results are rejected) in foundResults list. Quality comparisons with results from other providers throws an exception and prevents completion of the search.
I believe that findSeason() may suffer from the same problem (NoneType in return list), though that was on @tolstyak's branch I discovered it. At the time I just threw a rough fix on it (Conjuro/Sick-Beard@19770dd), but it would probably be better to find the root cause. findSeason() is somewhat larger to muddle through and right now I'm hungry, tired and got a headache, so I'll have to get back to it later, unless someone else wants to give it a whack.