Bugfix :: loadFromTVDB : Prevents corrupted data from TheTVDB

[Conjuro]

tv_shows.show_name in sickbeard.db can never be a NoneType. Patch prevents this from happening if someone has removed the seriesname attribute in the TVDB show entry.

http://www.sickbeard.com/forums/viewtopic.php?f=4&t=7249

[Conjuro]

Any suggestions for a good way to test it? I suppose I could stick a proxy between me and TVDB to alter the incoming data, just hoping for an easier/quicker solution.

[Conjuro]

Conjuro@a6775ad#commitcomment-3272009

Thanks, @thezoggy. That does feel like a neater way of doing it. I also replaced the else with except since else can only follow an except and has the opposite effect.

Hmm. Squash and forced push removed the commit comment reference, any way of replacing commits but retaining the comment history?

[thezoggy]

do you have a show/tvdbid that you use to test this code out with? / how did you find this issue?

[Conjuro]

Came across it while doing support in the forums. First one person, then another two reported the same issue. One using windows binary, one using git master also windows, and third using a different fork. Had them upload their databases and found it to be the same show (Person of Interest, tvdbid 248742) for all three. I checked the TVDB entry, but it's correct now and never went wrong in my own database, indicating it was only missing for a period less than 24 hours. I didn't question further, but I'd guess all three are in the same or at least neighboring time zones.

So far I've tested that the patch doesn't interfere with normal data, and using a custom python script that it behaves as expected. Unless someone can suggest a better way of testing, I'll try using a proxy to alter the data in real time while doing a "Force Full Update", when I get a chance.

[Conjuro]

I've now tested it by using a proxy to alter the SeriesName tag in the xml from thetvdb.com while using "Force Full Update". Sick Beard aborted the update and returned the proper error.

[VeNoMouS]

Nice conjuro :), re timezones, knightNZ (least i assume from his username) and myself are based in New Zealand