Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jquery ui 1.10.3 -> 1.10.4 #793

Merged
1 commit merged into from
Feb 6, 2014

Conversation

thezoggy
Copy link
Contributor

@thezoggy thezoggy commented Feb 3, 2014

Minor bugfixes, mainly for IE9 users.
-- http://jqueryui.com/changelog/1.10.4/

ghost pushed a commit that referenced this pull request Feb 6, 2014
Upgrade jquery ui 1.10.3 -> 1.10.4
@ghost ghost merged commit 6e25192 into midgetspy:development Feb 6, 2014
@drewfreyling
Copy link

@thezoggy Is there any particular reason we are using a really old school version of jquery? If not, I might submit a pull request to update it.

@thezoggy
Copy link
Contributor Author

Upgrading would require some code rewrites or using migrate plugin. There's no features in the newer jQuery that we are needing at this time... So just needed work for now

-----Original Message-----
From: "Drew Freyling" [email protected]
Sent: ‎2/‎20/‎2014 6:25 PM
To: "midgetspy/Sick-Beard" [email protected]
Cc: "thezoggy" [email protected]
Subject: Re: [Sick-Beard] Upgrade jquery ui 1.10.3 -> 1.10.4 (#793)

@thezoggy Is there any particular reason we are using a really old school version of jquery? If not, I might submit a pull request to update it.


Reply to this email directly or view it on GitHub:
#793 (comment)

@drewfreyling
Copy link

Ok cool. The lower startup overhead in 1.11.0 is nice to have but maybe not if it requires other code rewrites.

@thezoggy
Copy link
Contributor Author

No worries, I do plan to eventually get us up to current version of jquery.. but due to some of the things that was dropped in 1.8.x+ it means I'll have to go update some libs (qtip2) and add libs that they use to deal with the changes. Also it means I'll have to go rewrite some of our own code to deal with the lack of $browser for example. Not a huge deal but also something that can wait until I have some down time :)

@thezoggy thezoggy deleted the dev--jui_update branch April 12, 2014 23:40
gborri pushed a commit to gborri/Sick-Beard that referenced this pull request Sep 12, 2014
Add TokyoToshokanProvider support
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants