Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed missing initial messages (#2847) #2850

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

ghostoy
Copy link
Contributor

@ghostoy ghostoy commented Apr 2, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

socketio

Description of change

修复由于连接中间件执行时间长,而导致随机地无法收到客户端初始发送的若干消息的问题。

同时保证了客户端连接后按照如下的顺序执行:Controller中间件 -> OnWSConnection中间件和切面方法 -> OnWSMessage中间件和切面方法

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch coverage: 92.59% and project coverage change: -0.12 ⚠️

Comparison is base (97671fd) 81.62% compared to head (82b3428) 81.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   81.62%   81.50%   -0.12%     
==========================================
  Files         437      437              
  Lines       15768    15819      +51     
  Branches     3721     3731      +10     
==========================================
+ Hits        12870    12894      +24     
- Misses       2630     2652      +22     
- Partials      268      273       +5     
Impacted Files Coverage Δ
packages/socketio/src/framework.ts 86.61% <92.59%> (+0.52%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Apr 2, 2023
@czy88840616 czy88840616 merged commit 152812d into midwayjs:main Apr 2, 2023
@ghostoy ghostoy deleted the fix/socketio-events branch April 3, 2023 00:52
@ghostoy ghostoy mentioned this pull request Apr 3, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

3 participants