Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: entityManager chaos under multiple instances #3574

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72aacdf) 84.46% compared to head (4426343) 84.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3574   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files         491      491           
  Lines       46688    46668   -20     
  Branches     5574     5573    -1     
=======================================
- Hits        39433    39418   -15     
+ Misses       7214     7209    -5     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Jan 18, 2024
@czy88840616 czy88840616 merged commit 95aa13d into main Jan 18, 2024
6 checks passed
@czy88840616 czy88840616 deleted the remove_request_scope branch January 18, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

2 participants