feat(grpc): GRPCClients.createClient() supports multi services in one .proto file and returns void insted of T #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waitingsong
force-pushed
the
grpc
branch
6 times, most recently
from
5114ab2 to
48527dd
Compare
|
@czy88840616 测试之前过了，rebase 之后咋依赖出问题了呢： CI |
|
更新下 main |
没搞懂这是啥情况 CI rebase 之前是过了的呀，难道还是 这个相关的？ 不知道该咋写了：单开一个 case 报 |
waitingsong
force-pushed
the
grpc
branch
2 times, most recently
from
efc672f to
b6f1485
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4159 +/- ##
==========================================
+ Coverage 84.55% 85.14% +0.59%
==========================================
Files 491 514 +23
Lines 46778 49147 +2369
Branches 5601 5717 +116
==========================================
+ Hits 39551 41848 +2297
- Misses 7191 7268 +77
+ Partials 36 31 -5 ☔ View full report in Codecov by Sentry. |
|
看上去还是 grpc 的单测没过 |
waitingsong
force-pushed
the
grpc
branch
3 times, most recently
from
569e610 to
404776f
Compare
… .proto file, and returns void insted of T
…upports optional service property
waitingsong
changed the title
|
@czy88840616 单测过了。不过 GRPCClients.createClient() 返回类型改为了 |
czy88840616
approved these changes
Nov 6, 2024
之前新开的 case，结果一堆报错。我拆分下 |
waitingsong
force-pushed
the
grpc
branch
2 times, most recently
from
b51f8fc to
7127213
Compare
|
@czy88840616 终于过了～ |
czy88840616
pushed a commit
that referenced
this pull request
Dec 15, 2024
… .proto file and returns void insted of T (#4159) * feat(grpc): GRPCClients.createClient() supports multi services in one .proto file, and returns void insted of T * feat(grpc): param IGRPCClientServiceOptions of createGRPCConsumer() supports optional service property * test(grpc): multiple services case * chore(grpc): lint fix * test(grpc): update (cherry picked from commit 2d39d05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持单个
.proto文件内声明多个service