fix(leoric): keep multiple datasources from conflicting base model #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4192 +/- ##
==========================================
+ Coverage 84.55% 85.21% +0.66%
==========================================
Files 491 519 +28
Lines 46778 50103 +3325
Branches 5601 5942 +341
==========================================
+ Hits 39551 42693 +3142
- Misses 7191 7381 +190
+ Partials 36 29 -7 ☔ View full report in Codecov by Sentry. |
cyjake
force-pushed
the
fix-leoric-mutli-datasource
branch
from
eb8b1ce to
34b160b
Compare
czy88840616
pushed a commit
that referenced
this pull request
Dec 15, 2024
…4192) Co-authored-by: Jake Chen <[email protected]> (cherry picked from commit 774d751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Boneclass) might be polluted if multiple datasources were configured. this pr fixes this issue.