Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: catch _constructor_from_mgr from geopandas #606

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

bifbof
Copy link
Collaborator

@bifbof bifbof commented Feb 19, 2024

Recently the GeoPandas team had some issues with the _constructor_from_mgr and in a change they added here _geodataframe_constructor_with_fallback and this breaks our code. For our code to work they should have to use self._constructor, so we do that manually in our code to repair this.

closes #605

Verified

This commit was signed with the committer’s verified signature.
jrjohnson Jon Johnson
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18476c7) 93.39% compared to head (ce5b1c3) 93.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   93.39%   93.40%           
=======================================
  Files          33       33           
  Lines        2059     2061    +2     
  Branches      364      364           
=======================================
+ Hits         1923     1925    +2     
  Misses        126      126           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
jrjohnson Jon Johnson
@bifbof bifbof requested a review from NinaWie February 22, 2024 08:37
@NinaWie NinaWie merged commit 7ee696e into mie-lab:master Mar 1, 2024
8 checks passed
@bifbof bifbof deleted the failing_tests branch March 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Failing tests with geopandas 0.14.3
2 participants