Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 900 number lower in this test #1176

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Make the 900 number lower in this test #1176

merged 1 commit into from
Oct 16, 2020

Conversation

miekg
Copy link
Owner

@miekg miekg commented Oct 15, 2020

Original PR doesn't make clear why this is 900-now assuming we want to
cross the 14 bit length boundary.

Up to 900 creates a super large (>2^16) message. Not sure why that needs
testing.

Also remove the packs at lower sizes.

Original PR doesn't make clear why this is 900-now assuming we want to
cross the 14 bit length boundary.

Up to 900 creates a super large (>2^16) message. Not sure why that needs
testing.

Also remove the packs at lower sizes.

Signed-off-by: Miek Gieben <[email protected]>
@miekg miekg requested a review from tmthrgd as a code owner October 15, 2020 15:55
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #1176 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   55.11%   55.17%   +0.05%     
==========================================
  Files          42       42              
  Lines        9581     9581              
==========================================
+ Hits         5281     5286       +5     
+ Misses       3275     3271       -4     
+ Partials     1025     1024       -1     
Impacted Files Coverage Δ
server.go 68.88% <0.00%> (+0.30%) ⬆️
msg.go 74.56% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e0aee...d8f283a. Read the comment docs.

Copy link
Collaborator

@tmthrgd tmthrgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is still hitting the problematic boundary, LGTM.

@miekg miekg merged commit 95dddd3 into master Oct 16, 2020
@miekg miekg deleted the 900 branch October 16, 2020 09:55
aanm pushed a commit to cilium/dns that referenced this pull request Jul 29, 2022
Original PR doesn't make clear why this is 900-now assuming we want to
cross the 14 bit length boundary.

Up to 900 creates a super large (>2^16) message. Not sure why that needs
testing.

Also remove the packs at lower sizes.

Signed-off-by: Miek Gieben <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants