Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling RR.Header more than once per RR #891

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Jan 4, 2019

Header is an interface method so there's non-zero overhead when calling it. This should be ever so slightly faster.

Header is an interface method so there's non-zero overhead when calling
it.
This is equivilant (while also clearing Rdlength) while being simpler.
@tmthrgd tmthrgd requested a review from miekg January 4, 2019 06:54
@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #891 into master will increase coverage by 0.07%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   56.37%   56.45%   +0.07%     
==========================================
  Files          41       41              
  Lines       10031    10031              
==========================================
+ Hits         5655     5663       +8     
+ Misses       3354     3348       -6     
+ Partials     1022     1020       -2
Impacted Files Coverage Δ
sanitize.go 100% <100%> (ø) ⬆️
sig0.go 64.28% <100%> (-1.24%) ⬇️
update.go 71.92% <100%> (+2.11%) ⬆️
dnssec.go 58.74% <92.3%> (+0.46%) ⬆️
server.go 66.43% <0%> (+0.46%) ⬆️
msg.go 78.05% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b955100...337385e. Read the comment docs.

@miekg miekg merged commit b9e1e75 into miekg:master Jan 4, 2019
@tmthrgd tmthrgd deleted the rr-header branch January 4, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants