Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and unify various returns #893

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Jan 4, 2019

This is cosmetic but makes the library a little simpler and more uniform.

@tmthrgd tmthrgd requested a review from miekg January 4, 2019 08:21
@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #893 into master will increase coverage by 0.04%.
The diff coverage is 48.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   56.37%   56.42%   +0.04%     
==========================================
  Files          41       41              
  Lines       10032    10009      -23     
==========================================
- Hits         5656     5648       -8     
+ Misses       3355     3339      -16     
- Partials     1021     1022       +1
Impacted Files Coverage Δ
tlsa.go 0% <0%> (ø) ⬆️
xfr.go 0% <0%> (ø) ⬆️
smimea.go 0% <0%> (ø) ⬆️
labels.go 93.33% <100%> (-0.07%) ⬇️
server.go 65.8% <100%> (-0.17%) ⬇️
msg.go 76.88% <42.85%> (-0.51%) ⬇️
client.go 63.86% <57.14%> (+2.35%) ⬆️
privaterr.go 68.85% <60%> (+0.59%) ⬆️
tsig.go 41.23% <66.66%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34be74d...c9ecb20. Read the comment docs.

@miekg miekg merged commit 513c1ff into miekg:master Jan 4, 2019
@tmthrgd tmthrgd deleted the simplify-return branch January 4, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants