In LLC 3.58 clicking 'Show file' after export crashes Finder #1762

danmeek · 2023-10-29T04:44:39Z

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Try with the newest version from GitHub (also it might have been fixed in latest nightly build)
Read the documentation and FAQ, Known issues, Troubleshooting
Search for your problem under Issues or Discussions
If you have a problem only with a particular file (or file type), use this form instead
Windows 7, 8 and 8.1 are no longer supported. This is not a question about Windows 8.1 or older.

Operating System

MacOS 13

Steps to reproduce

I'm running MacOS Ventura 13.4 and LossLessCut 3.58. Since I updated from 3.56, I noticed that when my export is done and I click the 'Show' button, Finder crashes hard. I've done all the obvious things like restarting the device and de- and re-installing 3.58 but the problem persists. When I went back to 3.56 the problem went away again.

Steps to reproduce

Open LLC 3.58
Open a video file
Edit the file
Hit export
When the export complete notice appears, click 'Show'
sirens in the distance

Expected behavior

Clicking 'Show' in 3.56 opens a Finder window (or foregrounds one with the folder in question) and highlights the first of the exported files.

Actual behavior

Finder crashes and I have to relaunch it.

Share log

index-3ee52d33.js:299 Version 3.58.0
index-3ee52d33.js:298 userOpenFiles
index-3ee52d33.js:298 /Users/daniel/Downloads/completely benign movie file.mp4
index-3ee52d33.js:298 loadMedia /Users/daniel/Downloads/completely benign movie file.mp4 undefined undefined
index-3ee52d33.js:298 State reset
index-3ee52d33.js:298 Loading EDL file llc /Users/daniel/Downloads/completely benign movie file-proj.llc undefined
index-3ee52d33.js:298 onDurationChange 46.902993
index-3ee52d33.js:298 outSegTemplateOrDefault ${FILENAME}-${CUT_FROM}-${CUT_TO}${SEG_SUFFIX}${EXT}
index-3ee52d33.js:167 customTagsByFile {}
index-3ee52d33.js:167 paramsByStreamId Map(0) {size: 0}
index-3ee52d33.js:167 Cutting from start to 23.50764533439745
index-3ee52d33.js:160 STDERR:
index-3ee52d33.js:160 Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/Users/daniel/Downloads/completely benign movie file.mp4':
Metadata:
major_brand : isom
minor_version : 512
compatible_brands: isomiso2avc1mp41
title : Project 8
date : 2023-10-24
encoder : Lavf60.5.100
Duration: 00:00:46.90, start: 0.000000, bitrate: 1432 kb/s
Stream #0:00x1: Video: h264 (High) (avc1 / 0x31637661), yuv420p(progressive), 720x1080 [SAR 1:1 DAR 2:3], 1295 kb/s, 30 fps, 30 tbr, 15360 tbn (default)
Metadata:
handler_name : VideoHandler
vendor_id : [0][0][0][0]
encoder : Lavc60.11.100 libx264
Stream #0:10x2: Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 128 kb/s (default)
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Output #0, mp4, to '/Users/daniel/Downloads/completely benign movie file-00.00.00.000-00.00.23.508-seg1.mp4':
Metadata:
major_brand : isom
minor_version : 512
compatible_brands: isomiso2avc1mp41
title : Project 8
date : 2023-10-24
encoder : Lavf60.3.100
Stream #0:0(und): Video: h264 (High) (avc1 / 0x31637661), yuv420p(progressive), 720x1080 [SAR 1:1 DAR 2:3], q=2-31, 1295 kb/s, 30 fps, 30 tbr, 15360 tbn (default)
Metadata:
handler_name : VideoHandler
vendor_id : [0][0][0][0]
encoder : Lavc60.11.100 libx264
Stream #0:1(und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 128 kb/s (default)
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream mapping:
Stream #0:0 -> #0:0 (copy)
Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
frame= 0 fps=0.0 q=-1.0 size= 0kB time=-00:00:00.06 bitrate= -0.0kbits/s speed=N/A
[mp4 @ 0x1338056f0] Starting second pass: moving the moov atom to the beginning of the file
frame= 708 fps=0.0 q=-1.0 Lsize= 4250kB time=00:00:23.50 bitrate=1481.6kbits/s speed=1.33e+03x
video:3856kB audio:369kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.612256%
index-3ee52d33.js:167 Cutting from 24.007645 to end
index-3ee52d33.js:160 STDERR:
index-3ee52d33.js:160 Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/Users/daniel/Downloads/completely benign movie file.mp4':
Metadata:
major_brand : isom
minor_version : 512
compatible_brands: isomiso2avc1mp41
title : Project 8
date : 2023-10-24
encoder : Lavf60.5.100
Duration: 00:00:46.90, start: 0.000000, bitrate: 1432 kb/s
Stream #0:00x1: Video: h264 (High) (avc1 / 0x31637661), yuv420p(progressive), 720x1080 [SAR 1:1 DAR 2:3], 1295 kb/s, 30 fps, 30 tbr, 15360 tbn (default)
Metadata:
handler_name : VideoHandler
vendor_id : [0][0][0][0]
encoder : Lavc60.11.100 libx264
Stream #0:10x2: Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 128 kb/s (default)
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Output #0, mp4, to '/Users/daniel/Downloads/completely benign movie file-00.00.24.008-00.00.46.903-seg2.mp4':
Metadata:
major_brand : isom
minor_version : 512
compatible_brands: isomiso2avc1mp41
title : Project 8
date : 2023-10-24
encoder : Lavf60.3.100
Stream #0:0(und): Video: h264 (High) (avc1 / 0x31637661), yuv420p(progressive), 720x1080 [SAR 1:1 DAR 2:3], q=2-31, 1295 kb/s, 30 fps, 30 tbr, 15360 tbn (default)
Metadata:
handler_name : VideoHandler
vendor_id : [0][0][0][0]
encoder : Lavc60.11.100 libx264
Stream #0:1(und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 128 kb/s (default)
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream mapping:
Stream #0:0 -> #0:0 (copy)
Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
frame= 0 fps=0.0 q=-1.0 size= 0kB time=-00:00:00.16 bitrate= -0.0kbits/s speed=N/A
[mp4 @ 0x127605770] Starting second pass: moving the moov atom to the beginning of the file
frame= 689 fps=0.0 q=-1.0 Lsize= 3892kB time=00:00:22.87 bitrate=1394.0kbits/s speed=1.56e+03x
video:3507kB audio:360kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.649409%

mifi · 2023-10-29T05:08:38Z

Wow I was wondering if it’s just me. Probably a bug in Finder triggered by electron’s showItemInFolder

lossless-cut/src/dialogs/index.jsx

Line 569 in 308bb2b

if (value) shell.showItemInFolder(filePath);

Will do some googling.

relevant electron code: [NSWorkspace sharedWorkspace] selectFile:path_string
https://github.com/electron/electron/blob/652f995128de858c7a68fad853f56e80e0c2c222/shell/common/platform_util_mac.mm#L159

rd-sf · 2023-10-31T21:00:22Z

Same bug. M2Pro MacOS 14.0

mifi · 2023-11-01T12:38:56Z

I just tested some more. If I open developer tools and then write the following:

window.require('electron').shell.showItemInFolder('/Users/mifi/Library')

...it also freezes Finder the same way. Note that it doesn't crash finder but it causes it to freeze. But if I close LosslessCut, finder un-freezes

mifi · 2023-11-01T12:53:15Z

found the electron bug: electron/electron#38540 (comment)

danmeek · 2023-11-02T03:20:11Z

Amazing detective work! Is that something the LLC creators can fix themselves?

…

On Wed, 1 Nov 2023 at 23:53, Mikael Finstad ***@***.***> wrote: found the electron bug: electron/electron#38540 (comment) <electron/electron#38540 (comment)> — Reply to this email directly, view it on GitHub <#1762 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZQH42O6QNWPCTHYTTIRTYCJA4PAVCNFSM6AAAAAA6USGKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYHEYDKOBWGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

mifi · 2023-11-02T10:52:32Z

Well i am the llc creator. I think I will wait a bit and see if it gets fixed in electron. If not, then I have to find some kind of workaround, or downgrade electron.

danmeek · 2023-11-02T22:40:43Z

Oh pardon me! I hadn't realised. I'm a huge fan of your work and grateful for your efforts.

…

On Thu, 2 Nov 2023 at 21:52, Mikael Finstad ***@***.***> wrote: Well i am the llc creator. I think I will wait a bit and see if it gets fixed in electron. If not, then I have to find some kind of workaround, or downgrade electron. — Reply to this email directly, view it on GitHub <#1762 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZQH4A6SQHBFE2ZGP7A7LYCN3PZAVCNFSM6AAAAAA6USGKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGUYDAMZSGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

xinplus99 · 2023-12-01T05:04:51Z

Hi, same issue with LLC 3.58.0 on my M1 Macbook Air (MacOS 14.1.1)
If I click Show File, Finder will be frozen for about 45-60 sec. But I can still use LLC while Finder is frozen.
However after export completes, if I click Close instead of Show File, Finder is all good.
Hope it can be fixed in next update. Thx

mifi · 2023-12-02T12:31:55Z

i will fix it with this workaround electron/electron#38540 (comment)

danmeek · 2023-12-04T00:03:29Z

Thanks for your hard work. It's a small thing but it will make my workflow a lot smoother. I appreciate it! Best, Daniel

…

On Sun, 3 Dec 2023 at 01:27, Mikael Finstad ***@***.***> wrote: Closed #1762 <#1762> as completed via 6880422 <6880422> . — Reply to this email directly, view it on GitHub <#1762 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZQH7GZO7XZJPCEKH7CE3YHM3DNAVCNFSM6AAAAAA6USGKYOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGEZDSMJQHAYDEMY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

mifi added the bug label Oct 29, 2023

mifi mentioned this issue Nov 1, 2023

[Bug]: showItemInFolder hangs macOS Finder for about a minute electron/electron#38540

Open

3 tasks

mifi added Electron Upstream electron or electron builder bug MacOS labels Nov 4, 2023

mifi closed this as completed in 6880422 Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In LLC 3.58 clicking 'Show file' after export crashes Finder #1762

In LLC 3.58 clicking 'Show file' after export crashes Finder #1762

danmeek commented Oct 29, 2023

mifi commented Oct 29, 2023 •

edited

Loading

rd-sf commented Oct 31, 2023

mifi commented Nov 1, 2023

mifi commented Nov 1, 2023

danmeek commented Nov 2, 2023 via email

mifi commented Nov 2, 2023

danmeek commented Nov 2, 2023 via email

xinplus99 commented Dec 1, 2023 •

edited

Loading

mifi commented Dec 2, 2023

danmeek commented Dec 4, 2023 via email

In LLC 3.58 clicking 'Show file' after export crashes Finder #1762

In LLC 3.58 clicking 'Show file' after export crashes Finder #1762

Comments

danmeek commented Oct 29, 2023

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Operating System

Steps to reproduce

Expected behavior

Actual behavior

Share log

mifi commented Oct 29, 2023 • edited Loading

rd-sf commented Oct 31, 2023

mifi commented Nov 1, 2023

mifi commented Nov 1, 2023

danmeek commented Nov 2, 2023 via email

mifi commented Nov 2, 2023

danmeek commented Nov 2, 2023 via email

xinplus99 commented Dec 1, 2023 • edited Loading

mifi commented Dec 2, 2023

danmeek commented Dec 4, 2023 via email

mifi commented Oct 29, 2023 •

edited

Loading

xinplus99 commented Dec 1, 2023 •

edited

Loading