-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint 9 #1589
Comments
Waiting for all plugins to support it. |
Just saw that Typescript-Eslint released they v8 yesterday. Thank you. |
Two things need to happen:
|
Got it, seems to be a heated discussion on Thank you! |
Now that we have typescript-eslint v8, the remaining blocker is eslint-plugin-import. And I'm not sure what to do about that except for waiting. The fork could work, but I feel reluctant. Any opinions? |
@mightyiam perhaps we could import this plugin through compat layers as suggested in this comment? |
https://github.com/eslint/rewrite/tree/9250f2842456dff373508dce50cff536e32d8686/packages/compat usage seems trivial. I wonder though how do we know that all fixed rules still work... |
Hi everyone, hi @mightyiam ! Following up with this issue I created two PRs. Since the |
I'm afraid #1733 is a dead-end because it does not prevent this:
|
@mightyiam my understanding is You can see that works is in progress at import-js/eslint-plugin-import#2996 I'm afraid it might take a long time and I think I can't do much more than this to PRs in the mean time, but let me know! |
Can we merge #1732 as a workaround until we find a more stable solution? |
What about waiting for ESLint v9 support in eslint-plugin-import? |
@mightyiam eslint-plugin-import just dropped a new release supporting flat configs. |
any updates on eslint 9 support? |
It looks like there will be movement on that on the eslint-plugin-import side shortly! import-js/eslint-plugin-import#3061 just got approved, which is blocking for import-js/eslint-plugin-import#2996. The latter should fix v9 support. |
Hey, sorry for not responding to this. Not sure how I missed it. Yes, what @TyIsI wrote. |
Hi, I was just setting up a project and saw that import-js/eslint-plugin-import#2996 was merged just a few minutes ago, so nothing should block the ESLint 9 support now (after it's been released of course) 🙂 |
A new eslint-plugin-import version has been released that supports eslint 9 now! |
I believe this was already merge by the renovate bot via #1790 👍 |
@mightyiam The package.json should be updated to reflect this - "eslint": "^8.0.1",
+ "eslint": ">=8.0.1", But this would fail dependencies tests |
@pnodet |
Oh, wait. I missed #1589 (comment) |
waiting for eslint-config-love to bring in new eslint-plugin-import that now supports v9 - mightyiam/eslint-config-love#1589 - mightyiam/eslint-config-love#1497 - mightyiam/eslint-config-love#1734
🔥 |
It would be awesome to add ESLint 9 support.
The text was updated successfully, but these errors were encountered: