Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a test for the typescript peer dep to match upstream #604

Closed
mightyiam opened this issue Jul 2, 2021 · 1 comment · Fixed by #664
Closed

Have a test for the typescript peer dep to match upstream #604

mightyiam opened this issue Jul 2, 2021 · 1 comment · Fixed by #664

Comments

@mightyiam
Copy link
Owner

https://github.com/standard/eslint-config-standard-with-typescript/blob/8c836dc44c4e8a1b73263259509df490c8e9fddf/package.json#L67

Does upstream support typescript@^3.9?

https://github.com/typescript-eslint/typescript-eslint#supported-typescript-version

I'd like us to have a test for this.

@mightyiam
Copy link
Owner Author

Actually, https://github.com/typescript-eslint/typescript-eslint#supported-typescript-version ... Upstream's attitude is to declare the support in the docs and then to declare * in the peerDep, "to allow experimentation". And their code prints a warning when the typescript version you're using is not supported. We can do the same, I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant