Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules): new rule @typescript-eslint/ban-ts-comment #229

Closed
wants to merge 1 commit into from
Closed

feat(rules): new rule @typescript-eslint/ban-ts-comment #229

wants to merge 1 commit into from

Conversation

mightyiam
Copy link
Owner

@mightyiam
Copy link
Owner Author

@LinusU this new rule is removed from #224, where you had a reservation.

@LinusU
Copy link
Contributor

LinusU commented Feb 11, 2020

(originally posted in the other thread)

I actually think that @ts-ignore is a much cleaner way to signal something that isn't possible with TypeScript at the moment than just casting to any.

  • Since any already has a legitimate use case it's hard to search your entire codebase for it, and it doesn't stand out as much when you see it.
  • @ts-ignore lets you very easy add context on why you have to ignore it. Most of the time I will link to a TypeScript issue directly in the comment:
    // @ts-ignore https://github.com/microsoft/TypeScript/issues/26113

@mightyiam
Copy link
Owner Author

Obsolete by #285 .

@mightyiam mightyiam closed this May 16, 2020
@mightyiam mightyiam deleted the ban-ts-comment branch May 16, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbluhm toddbluhm Awaiting requested review from toddbluhm

@LinusU LinusU Awaiting requested review from LinusU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mightyiam @LinusU