-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced ApplicationsInventoryExceptionMapper to work with Quarkus 1.13.0 #22
Conversation
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 25 28 +3
===========================================
Files 5 6 +1
Lines 41 48 +7
Branches 5 5
===========================================
+ Hits 41 48 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused imports should be removed - ApplicationsDependency.java lines 23-25
Considering 9ad6533 works and that Quarkus 1.13.1 has been released in the meantime, I'll keep this PR with a further commit to bump the version to be the latest available. |
resolve #21
Quarkus 1.13.0 introduced
RestDataPanacheExceptionMapper
for wrapping REST Data Panache exceptionsRestDataPanacheException
(quarkusio/quarkus#15278).We already had an
ExceptionMapper
(ResourcesExceptionHandler
) that was not able to fire anymore because the exceptions from REST Data Panache methods becameRestDataPanacheException
and notWebApplicationException
anymore.So this PR :
ApplicationsInventoryException
to be used for throwing exceptions from application's codeApplicationsInventoryExceptionMapper
for managingRestDataPanacheException
with this approach:ApplicationsInventoryException
, it manages itRestDataPanacheExceptionMapper
(with the specifictestAddBadPayload
test for this case)ApplicationsDependency
accordingly to the changes aboveFurther changes from quarkusio/quarkus#16294