Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yielding parentComponent=this raises computed property override deprecation #23

Closed
alanlalonde opened this issue Jul 5, 2019 · 1 comment · Fixed by #24
Closed

Yielding parentComponent=this raises computed property override deprecation #23

alanlalonde opened this issue Jul 5, 2019 · 1 comment · Fixed by #24

Comments

@alanlalonde
Copy link
Contributor

Usage of parentComponent=this has been flagged for deprecation in favor of using manual setters. Here is the deprecation message, as it pertains to the implementation from ember-paper-stepper.

DEPRECATION: The <app-name@component:paper-step::ember733>#parentComponent computed property was just overriden. This removes the computed property and replaces it with a plain value, and has been deprecated. If you want this behavior, consider defining a setter which does it manually. [deprecation id: computed-property.override] See https://emberjs.com/deprecations/v3.x#toc_computed-property-override for more details.

As such, fixing it here would require bumping versions in whichever dependency is used by that package (it does not seem to directly depend on ember-composability-tools).

@alanlalonde alanlalonde changed the title Yielding parentComponent=this raises computed property override deprecation Yielding parentComponent=this raises computed property override deprecation Jul 5, 2019
@alanlalonde alanlalonde reopened this Jul 5, 2019
@alanlalonde
Copy link
Contributor Author

Whoops, tricky click finger. I opened a PR that fixes the computed property by adding the recommended getter and setter, as per the deprecation guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant