bump ember-composability-tools to v0.0.12 to fix deprecation warnings #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…puted property overridability
|
I legitimately thought that a new version would be rolled into the next beta release due to the package.json entry being forward compatible. Sorry about not following through on this. However, build is failing and I can't dig too deep right now. |
|
@conormag can you try running the CI build again? It seems like the build failed due to issues with ember 3.12.0 being released around the same time. It shouldn't be an issue anymore. |
|
@conormag please merge from master and try running Travis build one more time. The failing tests should be fixed now and your merge will definitely fix a lot of deprecations. |
|
@alanlalonde hi, everything passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-paper is causing deprecation warnings for computed property overrides. The issue is stemming from
ember-composability-toolsand is fixed in version of v0.0.12 of that package. The related issue is here.