eliminate warnings #520
Merged
eliminate warnings #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch eliminates all the compiler warninsg I get under Xcode 16.0 beta 4: PickerNameProviderMacro.swift:58:13 Initialization of immutable value 'types' was never used; consider replacing with assignment to '_' or removing it RefCounted.swift:24:9 Result of call to 'initRef()' is unused Array.swift:301:5 @discardableResult declared on a function returning Void is unnecessary Packed.swift:13:13 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) Wrapped.swift:143:28 Value 'node' was defined but never used; consider replacing with boolean test Wrapped.swift:511:17 Result of call to 'retain()' is unused ObjectCollectionTests.swift:41:81 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) ObjectCollectionTests.swift:56:19 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) VariantCollectionTests.swift:38:19 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) VariantCollectionTests.swift:48:28 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:)
mayoff
force-pushed
the
eliminate-warnings
branch
from
f836329 to
9c54b78
Compare
|
Forgot to build the test cases before opening the PR. The force push 9c54b78 eliminates the four warnings from the test cases. |
|
Oh, delightful! I'll review tonight! |
migueldeicaza
pushed a commit
that referenced
this pull request
Jan 19, 2025
This patch eliminates all the compiler warninsg I get under Xcode 16.0 beta 4: PickerNameProviderMacro.swift:58:13 Initialization of immutable value 'types' was never used; consider replacing with assignment to '_' or removing it RefCounted.swift:24:9 Result of call to 'initRef()' is unused Array.swift:301:5 @discardableResult declared on a function returning Void is unnecessary Packed.swift:13:13 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) Wrapped.swift:143:28 Value 'node' was defined but never used; consider replacing with boolean test Wrapped.swift:511:17 Result of call to 'retain()' is unused ObjectCollectionTests.swift:41:81 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) ObjectCollectionTests.swift:56:19 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) VariantCollectionTests.swift:38:19 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) VariantCollectionTests.swift:48:28 'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:) Co-authored-by: Rob Mayoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch eliminates all the compiler warninsg I get under Xcode 16.0 beta 4:
PickerNameProviderMacro.swift:58:13
Initialization of immutable value 'types' was never used; consider replacing with assignment to '_' or removing it
RefCounted.swift:24:9
Result of call to 'initRef()' is unused
Array.swift:301:5
@discardableResult declared on a function returning Void is unnecessary
Packed.swift:13:13
'append(value:)' is deprecated: This method signature has been deprecated in favor of append(_:)
Wrapped.swift:143:28
Value 'node' was defined but never used; consider replacing with boolean test
Wrapped.swift:511:17
Result of call to 'retain()' is unused