review feedback

miguelgrinberg · Sep 3, 2024 · dbe03be · dbe03be
1 parent 4edf33b
commit dbe03be
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/elasticsearch_dsl/search_base.py b/elasticsearch_dsl/search_base.py
@@ -717,6 +717,10 @@ def ensure_strings(
             if isinstance(fields, dict):
                 return {k: ensure_strings(v) for k, v in fields.items()}
             elif not isinstance(fields, (str, InstrumentedField)):
+                # we assume that if `fields` is not a any of [dict, str,
+                # InstrumentedField] then it is an iterable of strings or
+                # InstrumentedFields, so we convert them to a plain list of
+                # strings
                 return [str(f) for f in fields]
             else:
                 return str(fields)