Skip to content

Commit

Permalink
Revert "_websocket_handler waits on writer even after the socket is c…
Browse files Browse the repository at this point in the history
…losed"
  • Loading branch information
miguelgrinberg committed Dec 18, 2015
1 parent 1b56757 commit a4ffc8e
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions engineio/socket.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from __future__ import absolute_import
import time
import six
import socket

from . import packet
from . import payload
Expand Down Expand Up @@ -152,7 +150,7 @@ def writer():
try:
for pkt in packets:
ws.send(pkt.encode(always_bytes=False))
except socket.error:
except:
break

writer_task = self.server.start_background_task(writer)
Expand All @@ -175,5 +173,4 @@ def writer():
except ValueError:
pass
self.close(wait=False, abort=True)
self.queue.put(packet.Packet(packet.NOOP)) # wakeup the writer
writer_task.join()

0 comments on commit a4ffc8e

Please sign in to comment.