You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When using the msgpack serializer, packets that contain binary data are encoded as BINARY_EVENT or BINARY_ACK, however, the Javascript Socket.IO implementation does not use these types when using msgpack. Since msgpack can already efficiently transmit binary data, the binary data is inlined (which does work in python-socketio) and the type is left as EVENT or ACK (which is wrong in python-socketio).
To Reproduce
Steps to reproduce the behavior:
Configure a python-socketio server using serializer="msgpack"
Connect a Javascript client to it using the official Socket.IO implementation
Emit an event containing binary data from the server to the client
The client will fail to decode the message
Expected behavior
The BINARY_EVENT type should be encoded as EVENT, and the BINARY_ACK type should be encoded as ACK.
The text was updated successfully, but these errors were encountered:
Describe the bug
When using the msgpack serializer, packets that contain binary data are encoded as BINARY_EVENT or BINARY_ACK, however, the Javascript Socket.IO implementation does not use these types when using msgpack. Since msgpack can already efficiently transmit binary data, the binary data is inlined (which does work in python-socketio) and the type is left as EVENT or ACK (which is wrong in python-socketio).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The BINARY_EVENT type should be encoded as EVENT, and the BINARY_ACK type should be encoded as ACK.
The text was updated successfully, but these errors were encountered: