Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server and AsyncServer when emitting no data #420

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Fix Server and AsyncServer when emitting no data #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion socketio/asyncio_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,10 @@ async def _emit_internal(self, sid, event, data, namespace=None, id=None):
# as a single argument
if isinstance(data, tuple):
data = list(data)
else:
elif data is not None:
data = [data]
else:
data = []
await self._send_packet(sid, packet.Packet(
packet.EVENT, namespace=namespace, data=[event] + data, id=id,
binary=None))
Expand Down
4 changes: 3 additions & 1 deletion socketio/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,10 @@ def _emit_internal(self, sid, event, data, namespace=None, id=None):
# as a single argument
if isinstance(data, tuple):
data = list(data)
else:
elif data is not None:
data = [data]
else:
data = []
self._send_packet(sid, packet.Packet(packet.EVENT, namespace=namespace,
data=[event] + data, id=id,
binary=binary))
Expand Down