Don't swallow exceptions thrown in callbacks #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not execute callback function inside try catch block because it will swallow the exception. New function safeReadDirSync only catches the EACCES exception thrown by readdirSync.
|
Nice, I agree with your point of view |
|
Nice find! Thanks for the PR! |
mihneadb
approved these changes
Apr 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not execute callback function inside try catch block because it will
swallow the exception. New function safeReadDirSync only catches the
EACCES exception thrown by readdirSync.
I am using node-directory-tree to test a directory full of json files with jest. I want to make sure that they all have valid syntax and other properties. I do all my assertions inside the callback function. There I found a bug in which my assertion errors were not being reported by the test runner because of a try catch block swallowing them inside directory-tree.js. This PR fixes it and adds a test case.