Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an item type #28

Merged
merged 3 commits into from
Apr 28, 2017
Merged

added an item type #28

merged 3 commits into from
Apr 28, 2017

Conversation

GabrielDelepine
Copy link

@GabrielDelepine GabrielDelepine commented Apr 19, 2017

I created constants but unfortunately I cannot export them because we need to keep the compatibility with the actual implementation

const dirTree = require('directory-tree');

When Node will natively support ES6 import, it can be interesting to do

in lib/directory-tree.js

export constants
export default directoryTree
import directoryTree, { constants } from 'directory-tree'

Closing issue #26

Copy link
Owner

@mihneadb mihneadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! You need to rebase on the last master though.

@@ -43,4 +49,4 @@ function directoryTree (path, options, onEachFile) {
return item;
}

module.exports = directoryTree;
module.exports = directoryTree
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the semicolon here pls.

@GabrielDelepine
Copy link
Author

Hi @mihneadb, the PR is ready to be merge. Do you think I should make more modification ?

@mihneadb
Copy link
Owner

Thanks!

@mihneadb mihneadb merged commit 29447e4 into mihneadb:master Apr 28, 2017
@manatarms manatarms mentioned this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants