Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default attributes only "name", "path" and "children" #93

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Default attributes only "name", "path" and "children" #93

merged 5 commits into from
Sep 15, 2021

Conversation

Momijiichigo
Copy link
Contributor

@Momijiichigo Momijiichigo commented Aug 23, 2021 •
edited
Loading

I changed the code a little bit to make default attributes only "name", "path" and "children".
issue thread

@mihneadb
Copy link
Owner

mihneadb commented Sep 1, 2021

Thanks for this! Can you please merge the latest master so GIthub checks are included? It seems tests are not passing.

@Momijiichigo
Copy link
Contributor Author

Hi! I included Github checks! Please check the test script where I changed, to produce the same result as before
(i.e. I added attributes: ['size','type','extension'] option in the test code.)

mihneadb
mihneadb approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@mihneadb mihneadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mihneadb mihneadb merged commit 40f8661 into mihneadb:master Sep 15, 2021
@loshchini
Copy link

loshchini commented Sep 22, 2021 •
edited
Loading

Hi! The release with this fix ruined semver 😢

@mihneadb
Copy link
Owner

Sorry to hear that. You mean 2.4.0?

@loshchini
Copy link

Yeah, specifically, removing from default attributes "size", "extension" and "type" was breaking changes. Just paying attention :)

@mihneadb
Copy link
Owner

You're right, it should have turned into 3.0.0 since it is a breaking change. Sorry about that, will make a release. Thanks for notifying!

@mihneadb
Copy link
Owner

Deprecated 2.4.0, can't unpublish it now. Published 3.0.0.
Thanks again.

@loshchini
Copy link

Thanks for reaction!

@mihneadb mihneadb mentioned this pull request Sep 22, 2021
Closed
zhammer added a commit to zhammer/writing that referenced this pull request Nov 2, 2021
@zhammer
fix for mihneadb/node-directory-tree#93
aa3d323
zhammer added a commit to zhammer/writing that referenced this pull request Nov 2, 2021
@zhammer
deps (#29)
edcc9fe 
* yarn upgrade

* upgrade lotta deps

* fix for mihneadb/node-directory-tree#93

* update server version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihneadb mihneadb mihneadb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Momijiichigo @mihneadb @loshchini