New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ExtensionLoader] Prioritize extension classpath over app classpath #433

Merged

AntsyLich merged 1 commit into mihonapp:main from beer-psi:fix/child-first-class-loading

Feb 24, 2024

Contributor

beer-psi commented Feb 19, 2024 •

edited

Loading

This PR introduces a PathClassLoader subclass that searches for classes in order of system, child, parent.

This is most useful when extensions use a dependency that the app may have transitively pulled in, causing conflicts and runtime errors.

Tested on ~15 other extensions, they still work fine after the change.

Closes #432


          [ExtensionLoader] Prioritize extension classpath over app classpath

c2bbc85

AntsyLich merged commit ab02568 into mihonapp:main

1 check passed

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet