Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed few MSVC warnings and fixed a YamlWriter bug making produced YAML traces invalid. #2

Merged
merged 4 commits into from
Feb 4, 2015

Conversation

wmamrak
Copy link
Contributor

@wmamrak wmamrak commented Feb 3, 2015

No description provided.

@mikael-s-persson mikael-s-persson merged commit 31f71ea into mikael-s-persson:master Feb 4, 2015
@mikael-s-persson
Copy link
Owner

Thanks for the fixes.

I changed a few things that I didn't like too much in terms of style (using ".operator" syntax, using a lambda for a single-use function call, etc..).

I also fixed the issue we discussed about warnings of narrowing integer conversions. I hope that fix works OK on your end (MSVC). I had to refactor quite a bit of stuff for that fix, so hopefully nothing broke in the process.

thanks.

@wmamrak
Copy link
Contributor Author

wmamrak commented Feb 4, 2015

thanks,

I decided upon operator syntax beacuse it required less key strokes than a cast, and lambda was just to not pollute the file with very local code. I believe it is arguably a better style to use lambda for single-use function call instead of a typical function. :-)

The refactorization removed all the warnings about precision loss. There are literally few others I can eliminate on my own. The converter seems to work ok as well.

thanks.

@Asher- Asher- mentioned this pull request Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants