fix: avoid issues with events_file_path having spaces

If the user used a path with spaces for their config.events_file_path setting, it caused an issue. No issues like this have been reported though.
mikavilpas · May 13, 2024 · a6d918f · a6d918f
1 parent e375060
commit a6d918f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lua/yazi.lua b/lua/yazi.lua
@@ -34,7 +34,7 @@ function M.yazi(config, path)
 
   os.remove(config.chosen_file_path)
   local cmd = string.format(
-    'yazi "%s" --local-events "rename,delete,trash,move" --chooser-file "%s" > %s',
+    'yazi "%s" --local-events "rename,delete,trash,move" --chooser-file "%s" > "%s"',
     path_utils.escape_path_for_cmd(path),
     config.chosen_file_path,
     config.events_file_path

diff --git a/tests/yazi/open_dir_spec.lua b/tests/yazi/open_dir_spec.lua
@@ -25,7 +25,7 @@ describe('when the user set open_for_directories = true', function()
     vim.api.nvim_command('edit /')
 
     assert.stub(api_mock.termopen).was_called_with(
-      'yazi "/" --local-events "rename,delete,trash,move" --chooser-file "/tmp/yazi_filechosen" > /tmp/yazi.nvim.events.txt',
+      'yazi "/" --local-events "rename,delete,trash,move" --chooser-file "/tmp/yazi_filechosen" > "/tmp/yazi.nvim.events.txt"',
       match.is_table()
     )
   end)

diff --git a/tests/yazi/yazi_spec.lua b/tests/yazi/yazi_spec.lua
@@ -41,7 +41,7 @@ describe('opening a file', function()
     })
 
     assert.stub(api_mock.termopen).was_called_with(
-      'yazi "/abc/test-file-\\$1.txt" --local-events "rename,delete,trash,move" --chooser-file "/tmp/yazi_filechosen" > /tmp/yazi.nvim.events.txt',
+      'yazi "/abc/test-file-\\$1.txt" --local-events "rename,delete,trash,move" --chooser-file "/tmp/yazi_filechosen" > "/tmp/yazi.nvim.events.txt"',
       match.is_table()
     )
   end)
@@ -55,7 +55,7 @@ describe('opening a file', function()
     })
 
     assert.stub(api_mock.termopen).was_called_with(
-      'yazi "/tmp/" --local-events "rename,delete,trash,move" --chooser-file "/tmp/yazi_filechosen" > /tmp/yazi.nvim.events.txt',
+      'yazi "/tmp/" --local-events "rename,delete,trash,move" --chooser-file "/tmp/yazi_filechosen" > "/tmp/yazi.nvim.events.txt"',
       match.is_table()
     )
   end)