fix: grug-far integration not being able to search outside of the cwd #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the grug-far integration (the default search and replace integration in yazi.nvim) where it was not able to search outside of the current working directory. This was due to the fact that the file path to search in was passed in `Files Filter` instead of in `Flags`, which is the correct place to pass the file path. MagicDuck/grug-far.nvim#146
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the grug-far integration (the default search and replace integration in yazi.nvim) where it was not able to search outside of the current working directory. This was due to the fact that the file path to search in was passed in
Files Filterinstead of inFlags, which is the correct place to pass the file path.MagicDuck/grug-far.nvim#146