Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage, related bug fixes #32

Merged
merged 6 commits into from
Jun 10, 2018
Merged

Conversation

mike42
Copy link
Owner

@mike42 mike42 commented Jun 10, 2018

Test coverage aside, some minor bug fixes are:

  • PNG reader
    • Fix for low-resolution files, where a pass with 0 vertical pixels would trigger a warning
    • Validate image/bit-depth combination, to throw Exception and avoid warnings
  • Include filename in error messages (when blob is loaded from file)
  • Indexed images:
    • Fixes off-by-one error in quantization which caused incorrect output for low color depths (2 or 3 levels).
    • Fixes warning thrown due to null being used as the default palette, [] is now used, and expanded out to contain one color.

@coveralls
Copy link

coveralls commented Jun 10, 2018

Pull Request Test Coverage Report for Build 120

  • 21 of 22 (95.45%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+53.5%) to 85.564%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Mike42/GfxPhp/IndexedRasterImage.php 1 2 50.0%
Totals Coverage Status
Change from base Build 112: 53.5%
Covered Lines: 1055
Relevant Lines: 1233

💛 - Coveralls

@mike42 mike42 merged commit 3ac1be9 into master Jun 10, 2018
@mike42 mike42 changed the title [WIP] Improve test coverage, related bug fixes Improve test coverage, related bug fixes Jun 10, 2018
@mike42 mike42 deleted the feature/test-coverage branch February 24, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants