Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path for show() in notebooks on Windows #2330

Closed
bottledspace opened this issue Dec 15, 2024 · 1 comment · Fixed by #2241
Closed

Fix path for show() in notebooks on Windows #2330

bottledspace opened this issue Dec 15, 2024 · 1 comment · Fixed by #2241

Comments

@bottledspace
Copy link

Small bug: Line 34 of trimesh/viewer/notebook.py should use os.path.join("templates","viewer.zip") instead of a forward slash, which does not work on the latest JupyterLab Desktop for Windows.
mikedh added a commit that referenced this issue Dec 15, 2024
@mikedh
fix for #2330
a25082b
@mikedh
Copy link
Owner

mikedh commented Dec 15, 2024

Thanks for the report! Yeah that seems like it would occur anywhere calling get_string('templates/...' on Windows, hopefully a25082b fixes this.

@mikedh mikedh mentioned this issue Jan 2, 2025
Merged
@mikedh mikedh closed this as completed in aed7eee Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release: Refactor Load Types mikedh/trimesh
2 participants
@mikedh @bottledspace