Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an optional weight parameter to the procrustes() method in registration.py. It allows to compensate for a few noisy points to make the transformation more robust. Didn't have the time to adjust the test file, but I tested the method visually for myself. Idea to test:
Add some noise to a subset of the source points, which should increase the returned cost. Now weigh the points that noise was added to less depending on the intensity of the noise. While this will probably increase the average cost even further, it should decrease the cost for the remaining points. (Option that I didn't implement, but I'm not sure if it's good: Instead of returning average cost, return weighted average cost).