Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axioms of intuitionistic logic to Heyting algebras #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sacsar
Copy link
Contributor

@sacsar sacsar commented Jun 10, 2016

I'd appreciate feedback on what to call these functions (and anything else, obviously). I took the names from Wikipedia, but they feel decidedly clumsy.

@mikeizbicki
Copy link
Owner

Oops! I didn't see this until just now. Sorry about that :(

The axioms themselves look good. There's two changes to make.

  1. Modify the names so that they start with theorem instead of axiom. These laws can all be proven from the Heyting laws that begin with law, so they are "theorems."
  2. Add these theorems to the test suite at https://github.com/mikeizbicki/subhask/blob/master/src/SubHask/TemplateHaskell/Test.hs#L63, this will both double check that the theorems are written correctly and that all the current instances of Heyting are correct.

@sacsar
Copy link
Contributor Author

sacsar commented Jun 30, 2016

Mentioning that I've seen this, but won't get to it for another week or so.

sacsar added 2 commits July 31, 2016 19:58
They might be axioms of intuitionist logic, but they're derived from the
Heyting laws.
@mikeizbicki
Copy link
Owner

I can't merge the changes until the travis checks pass.

@sacsar
Copy link
Contributor Author

sacsar commented Aug 2, 2016

First I have to figure out what the error means...

@sacsar
Copy link
Contributor Author

sacsar commented Oct 5, 2016

Is there an idiot's guide to figuring out how the tests work (besides what's in the readme)?

I'm failing with
‘theorem_Heyting_then1’ is not in scope at a reify In the splice: $(mkSpecializedClassTests [t| Bool |] [''Enum, ''Boolean])
but I have no idea how to get it (and presumably the other theorem methods) into scope.

@sacsar
Copy link
Contributor Author

sacsar commented Sep 9, 2017

@mikeizbicki It took me long enough, but the tests actually pass now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants