Require Ruby >= 2.5, add Psych 4 support, and get CI green #1478
Conversation
Co-authored-by: Vít Ondruch <[email protected]>
So that it doesn't timeout but fails in a standard way.
The standard `ruby/setup-ruby` action has all rubies that we need and has the added advantages of builtin gem caching and providing an up to date version of TruffleRuby, which behaves better.
It's failing consistently, and doesn't seem mail's fault.
…tested in CI) Co-authored-by: Josef Šimánek <[email protected]>
Provides a clear guidance on what versions of Ruby mail supports now and into the future.
deivid-rodriguez
force-pushed
the
drop-old-rubies-support
branch
from
aebf484 to
670bb87
Compare
deivid-rodriguez
force-pushed
the
drop-old-rubies-support
branch
from
670bb87 to
100a4f2
Compare
|
Awesome work @deivid-rodriguez - could @voxik or @simi please do one review through this and give it a thumbs up? This is a pretty major change and I would love another couple of eyes on it. Then I'll merge and we'll release Mail 2.8.0.rc1 into a stable branch |
|
I mainly care about a20fdd5, which looks good. I also like the clarification of the support policy. Other than that, I can't see anything worrisome. |
|
That maintenance/support policy sounds good. Does it square with the
existing policy of the extracted stdlib gems? Considering we'll be bound by
the support policies of those and future stdlib gem extractions.
…On Tue, Apr 19, 2022 at 5:39 AM Mikel Lindsaar ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#1478 (comment)>:
> @@ -48,7 +47,9 @@ our documentation, add new features—up to you! Thank you for pitching in.
## Compatibility
-Mail supports Ruby 1.8.7+, including JRuby and Rubinius.
+Mail supports Ruby 2.5+, including JRuby and TruffleRuby.
+
+As new versions of Ruby are released, Mail will be compatible with support for the "preview" and all "normal maintenance", "security maintenance" and the two most recent "end of life" versions listed at the [Ruby Maintenance Branches](https://www.ruby-lang.org/en/downloads/branches/) page. Pull requests to assist in adding support for new preview releases are more than welcome.
@deivid-rodriguez <https://github.com/deivid-rodriguez> @voxik
<https://github.com/voxik> I added this paragraph, seem reasonable to
you? @jeremy <https://github.com/jeremy> do you have any input?
—
Reply to this email directly, view it on GitHub
<#1478 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAABRZAHB5FJJ42NPN7AH3VF2SQ5ANCNFSM5TYNBCBQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
In my experience, the support policy of extracted stdlibs is not really established, but they are usually more aggressive than this when it comes to dropping support for old rubies. For example, net-imap 0.2.2 supports ruby 2.5+, while net-imap 0.2.3 (the latest version) supports ruby 2.6+. |
|
Looks good to me @deivid-rodriguez @voxik - let's get 1472 under control now. Then I'll release 2.8.0.rc1 |
| require 'mail/version_specific/ruby_1_8' | ||
| RubyVer = Ruby18 | ||
| end | ||
|
|
There was a problem hiding this comment.
Also Ruby18, given that we're dropping Ruby 1.8 support? The link you provided does not show any meaningful results in the first pages for me.
I unified the changes from #1472 and #1476 intended to get a base green CI line.
I tweaked #1476 to use safe loading by default but still fully support Psych 3.
Link to green actions run on my fork: https://github.com/deivid-rodriguez/mail/runs/6076144108?check_suite_focus=true.