Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Expand testcases with gradle project in root and gradle cli instead of gradlew #78

Merged
merged 4 commits into from
Aug 19, 2022

Conversation

mikepenz
Copy link
Owner

  • add example of gradle project in root (without module)

@mikepenz mikepenz added the other label Aug 19, 2022
- introduce handling when configuring the root module of a project
- add more comments to `gradle.ts` functions
…nstead with `\---`

- don't trim lines in the start to ensure we retrieve proper parent / child structure if output does not prefix line with `|`
@mikepenz
Copy link
Owner Author

Thank you for experimenting with this action @rwinch
I have seen that your sample usecase differs from the examples we currently had in our testcases. E.g. it being in the root, without module, also the output differs slightly.

This PR fixes the related issues, and also introduced a test-case covering this setup. In addition the repo now also includes a similar gradle project setup and runs the action on it.

@mikepenz
Copy link
Owner Author

Hi @jhutchings1 , this change should also resolve the errors from: https://github.com/jhutchings1/elasticsearch/runs/7885067801?check_suite_focus=true

Please see the successful run here: https://github.com/mikepenz/elasticsearch/runs/7916531712?check_suite_focus=true
(in addition Java 17 was needed, and the write permission for the dependency submission API, also needed to enable the dependency graph for the fork)

And the import in the dependency submission UI: https://github.com/mikepenz/elasticsearch/network/dependencies

@jhutchings1
Copy link

Thanks for digging in on this @mikepenz ! I've been recommending lots of folks try this Action out, so appreciate all your continuing investment into it.

@mikepenz
Copy link
Owner Author

Thank you very much @jhutchings1 really appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants