Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[weasyl] support favorites collections #1032

Closed
mikf opened this issue Sep 25, 2020 · 3 comments
Closed

[weasyl] support favorites collections #1032

mikf opened this issue Sep 25, 2020 · 3 comments

Comments

@mikf
Copy link
Owner

mikf commented Sep 25, 2020

See #977 (comment)

@mikf
Copy link
Owner Author

mikf commented Oct 11, 2020

@tux93 The new version supports favorites URLs like
https://www.weasyl.com/favorites?userid=…&feature=submit,
but any improvements from #1034 haven't been added yet.

@tux93
Copy link
Contributor

tux93 commented Oct 26, 2020

Thank you for the update, since API key auth was also added in 1.15.2 I gave it a try just now and noticed that downloading favourites is not quite behaving like I'd expect it to.

I set "directory": ["Weasyl", "{owner_login}"] for the Weasyl extractor in config.json, which works to put submissions into subfolders of the artists, but for favourites it collects everything in a subfolder of the person that favourited the submission. My expectation would be that favourites too would be sorted by the submitter, not who faved it.

gallery-dl -K shows this:

Keywords for directory names:
-----------------------------
category
  weasyl
owner_login
  fl4nn
subcategory
  favorite

Keywords for filenames and --filter:
------------------------------------
category
  weasyl
comments
  0
date
  2020-10-23 02:38:41
description
  <div><p>Patreon reward for AweShock! </p></div><div><br></div><div><p>Thaaaaat's retail! </p></div><div><br></div><div><p>Neumono @ Lagotrope</p></div>
embedlink
  None
extension
  png
favorited
  True
favorites
  2
filename
  trout-patreon-drivethru
folder_name
  None
folderid
  None
friends_only
  False
link
  https://www.weasyl.com/submission/1958162/patreon-drivethru
media[cover][][mediaid]
  7371851
media[cover][][url]
  https://cdn.weasyl.com/static/media/7d/3b/74/7d3b746d887c0b03e1b08eb89f9eb159ea567266594eb4166280e9c21b52fd48.png
media[submission][][links][cover][][mediaid]
  7371851
media[submission][][links][cover][][url]
  https://cdn.weasyl.com/static/media/7d/3b/74/7d3b746d887c0b03e1b08eb89f9eb159ea567266594eb4166280e9c21b52fd48.png
media[submission][][mediaid]
  7371850
media[submission][][url]
  https://cdn.weasyl.com/~trout/submissions/1958162/e3a3da62549f7b1b0392e3a6c299e2d27c53f1d4f433ecce0ccb70c50604a61c/trout-patreon-drivethru.png
media[thumbnail][][mediaid]
  7371852
media[thumbnail][][url]
  https://cdn.weasyl.com/static/media/62/7e/e1/627ee19c958b98b6a5d443cdf2084de48ba9f95c6b58c6478084a38f2b9bbd82.png
media[thumbnail-generated][][mediaid]
  7371852
media[thumbnail-generated][][url]
  https://cdn.weasyl.com/static/media/62/7e/e1/627ee19c958b98b6a5d443cdf2084de48ba9f95c6b58c6478084a38f2b9bbd82.png
media[thumbnail-generated-webp][][mediaid]
  7371853
media[thumbnail-generated-webp][][url]
  https://cdn.weasyl.com/static/media/9e/29/66/9e2966e1feb907d56a157aefb58fafa90acf9f168311059280d17b1e7ac58483.webp
owner
  Trout
owner_login
  trout
owner_media[avatar][][mediaid]
  6495263
owner_media[avatar][][url]
  https://cdn.weasyl.com/static/media/a9/92/a5/a992a56324f4bfd088c0a60c3295349014acac7752f8d14f4871f466c59738f6.gif
owner_media[banner][][mediaid]
  6495269
owner_media[banner][][url]
  https://cdn.weasyl.com/static/media/fb/66/9c/fb669c971bbb4576d1b30cdb5cfab005dc84166a367944f2091f978807c17dbf.png
posted_at
  2020-10-23T02:38:41+00:00Z
rating
  explicit
subcategory
  favorite
submitid
  1958162
subtype
  visual
tags[]
  - drivethrough
  - drivethru
  - female
  - male
  - public
  - sex
title
  (Patreon) drivethru
type
  submission
url
  https://cdn.weasyl.com/~trout/submissions/1958162/e3a3da62549f7b1b0392e3a6c299e2d27c53f1d4f433ecce0ccb70c50604a61c/trout-patreon-drivethru.png
views
  19

Note that owner_loginfor Directory and Filename differs

@tux93
Copy link
Contributor

tux93 commented Nov 15, 2020

Works for me now with v1.15.3

@mikf mikf closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants