Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deviantart] [Enhancement] Remove the "you need session cookies to download mature scraps" warning #1776

Closed
Scripter17 opened this issue Aug 15, 2021 · 5 comments

Comments

@Scripter17
Copy link
Contributor

So as it turns out, gallery-dl can already download mature scraps without session cookies

Trying to download an account with their only scrap being mature gives the following result

C:\Users\[REDACTED]\Desktop>gallery-dl --ignore-config https://www.deviantart.com/[REDACTED]/gallery/scraps
[deviantart][warning] API responded with 429 Too Many Requests. Using 1s delay.
[deviantart][warning] No session cookies set: Unable to fetch mature scraps.
* .\gallery-dl\deviantart\[REDACTED]\Scraps\[REDACTED]

Same test for an account with 5 mature scraps (429's removed)

C:\Users\[REDACTED]\Desktop>gallery-dl --ignore-config https://www.deviantart.com/[REDACTED]/gallery/scraps
[deviantart][warning] No session cookies set: Unable to fetch mature scraps.
* .\gallery-dl\deviantart\[REDACTED]\Scraps\[REDACTED]
* .\gallery-dl\deviantart\[REDACTED]\Scraps\[REDACTED]
* .\gallery-dl\deviantart\[REDACTED]\Scraps\[REDACTED]
* .\gallery-dl\deviantart\[REDACTED]\Scraps\[REDACTED]
* .\gallery-dl\deviantart\[REDACTED]\Scraps\[REDACTED]

I'll need to do some further testing to make sure it can always download mature scraps, but I'm fairly sure it can

@rautamiekka
Copy link
Contributor

Technically this is invalid cuz you aren't giving a link others can test for themselves.

@mikf
Copy link
Owner

mikf commented Aug 16, 2021

You're right, the Eclipse API now also returns "mature" rated works regardless of login status. That wasn't the case back when I added this warning. Thanks for letting me know they changed it.

429's removed

You haven't gotten your own pair of client-id and client-secret yet? (#1560 (comment))

@Scripter17
Copy link
Contributor Author

Scripter17 commented Aug 16, 2021

I did that a while ago but --ignore-config broke them when I was making sure you didn't need API keys for mature scraps

@biznizz
Copy link

biznizz commented Aug 19, 2021

So wait, does this mean that we don't need to export DA cookies (mainly userinfo) to a cookies.txt anymore to download a full gallery, scraps (mature or not) included?

@Scripter17
Copy link
Contributor Author

It means that, for quite a while it seems, you didn't need to do it even before I made the patch. The related pull request just removes the 6 lines of code that warns you to export cookies

Cookies were needed when the extractor was first made so it seems that deviantart changed something that made gallery-dl suddenly work. Usually site changes cause the opposite effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants