Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deviantart deviations search download the wrong results #2954

Closed
afterdelight opened this issue Sep 21, 2022 · 7 comments
Closed

[BUG] Deviantart deviations search download the wrong results #2954

afterdelight opened this issue Sep 21, 2022 · 7 comments

Comments

@afterdelight
Copy link

afterdelight commented Sep 21, 2022

i tried to download a deviant user named fu-reiji and his account was deactivated but his work is still search able on
https://www.deviantart.com/search/deviations?q=fu-reiji

results:

F:\downloader\deviant art>gallery-dl https://www.deviantart.com/search/deviations?q=fu-reiji
* .\Cryptid-Creations\510890840_Day 802# Garfeild's First Lasagna.png
* .\sandara\535480554_Mad Max - War Beasts.jpg
* .\yuumei\599726678_Replacement for the Stars.jpg
* .\Charlie-Bowater\670768474_Starfall.jpg
* .\TsaoShin\2B\454351411_Thank You - 4K on Facebook!.png

wrong users downloaded

test single link:

F:\downloader\deviant art>gallery-dl https://www.deviantart.com/fu-reiji/art/Part-timer-Homura-617581110
* .\Fu-reiji\617581110_Part timer Homura.jpg

the right user downloaded

@rautamiekka
Copy link
Contributor

rautamiekka commented Sep 21, 2022

Just download normally, before it's all gone. The search is useless, anyway; the search is doing as designed cuz the fu-reiji query means "search everywhere for an instance of fu-reiji", which, CWCID, is doing the same as Google normally does.

@afterdelight
Copy link
Author

I can't. The account was deactivated
https://www.deviantart.com/fu-reiji

@rautamiekka
Copy link
Contributor

You can, I just tried and have downloaded so many deac/banned DA accs I can't count that far.

@afterdelight
Copy link
Author

afterdelight commented Sep 21, 2022

Oh you were right, i can download the deactivated acc. But i still want to request fix for something general like
https://www.deviantart.com/search/deviations?q=nude+filter
which still downloaded the wrong users

@mikf
Copy link
Owner

mikf commented Sep 23, 2022

The Deviantart OAuth API, which is what gallery-dl uses, does not support fetching search results. The only thing that slightly resembles a search is the /browse/popular endpoint and its q parameter, so that's what gets internally used to emulate a search.

So fixing this and some other issues depends on gallery-dl updating its dA code base to using the Eclipse API, but how, when, and if this is going to get done is something I couldn't tell you. Maybe never or only for v2.0, since this would probably cause a lot of backwards incompatible changes.

There is a branch that hasn't seen any updates in more than 3 years, by the way: https://github.com/mikf/gallery-dl/tree/deviantart-rewrite

@afterdelight
Copy link
Author

well, now thats too bad

@SavvaI
Copy link

SavvaI commented Feb 5, 2023

The Deviantart OAuth API, which is what gallery-dl uses, does not support fetching search results. The only thing that slightly resembles a search is the /browse/popular endpoint and its q parameter, so that's what gets internally used to emulate a search.

So fixing this and some other issues depends on gallery-dl updating its dA code base to using the Eclipse API, but how, when, and if this is going to get done is something I couldn't tell you. Maybe never or only for v2.0, since this would probably cause a lot of backwards incompatible changes.

There is a branch that hasn't seen any updates in more than 3 years, by the way: https://github.com/mikf/gallery-dl/tree/deviantart-rewrite

So you say that there is literally no way to fetch images, if I want to combine two tags for example?

mikf added a commit that referenced this issue Feb 22, 2023
(#538, #1264, #2954, #2970, #3577)

Requires login to fetch any results, since the API endpoint raises an
error for not logged in requests.

TODO: parse HTML search results
@mikf mikf closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants