Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patreon Multi-Image Issue #383

Closed
biznizz opened this issue Aug 15, 2019 · 10 comments
Closed

Patreon Multi-Image Issue #383

biznizz opened this issue Aug 15, 2019 · 10 comments

Comments

@biznizz
Copy link

biznizz commented Aug 15, 2019

So, it looks like Patreon recently changed their image viewer recently. You can now look at multi-images in the same post easily. Bad news: they disabled they right click menu that when you try to open it on a picture (i.e. Open in New Tab, Save As, etc).

Relevant for this, it seems that gallery-dl, when it rips a Patreon page, will only rip the first image in a multi-image post.

@mikf
Copy link
Owner

mikf commented Aug 16, 2019

Could you provide an example of a multi-image post that gallery-dl fails to download all files from, so that I can investigate this issue? It would be really helpful if you put the HTML of such a post on pastebin etc., because I won't have full access to any paid rewards and their complete metadata.

@biznizz
Copy link
Author

biznizz commented Aug 16, 2019

https://pastebin.com/eLMBn7k6

An example of a post is in the pastebin link provided right below.

https://pastebin.com/aVELS0zM

(EDIT: Redacted my name and email from Source)

@mikf
Copy link
Owner

mikf commented Aug 17, 2019

Thanks for the example!
I've made some changes and it should now support multiple images per post. Please test this and let me know if it also works across a wider range than just this 1 post.

(The creator account I based the initial extractor on used attachments as a means to put multiple images in one post. Attachment files were supported, but not multiple image files ...)

@biznizz
Copy link
Author

biznizz commented Aug 18, 2019

Have tried it with the example previously given, and several other multi=image posts, and it still only rips the first image.

Still an issue with version 1.10.1

@mikf
Copy link
Owner

mikf commented Aug 18, 2019

Well, there hasn't been a new release yet. I also want to be sure everything works as it is supposed to before releasing the next version with b1728f5 in it.

Could you install the latest git snapshot and test it with that?
(pip install --upgrade https://github.com/mikf/gallery-dl/archive/master.zip)

@biznizz
Copy link
Author

biznizz commented Aug 18, 2019

Sorry, never used a snapshot build before. So, have now installed 1.10.2.dev0.

No change yet, the top/main image is still the only one being ripped.

@mikf
Copy link
Owner

mikf commented Aug 18, 2019

Even for the post you shared via pastebin? That one should get you 3 images - it does for me and i used it as a reference. If it doesn't, you aren't running the right version of gallery-dl (check with --version or the output with -v). Otherwise I'd need another example to see were things went wrong.

I'm sorry for all the extra work I'm putting on you, but, as I said, I don't have full access to Patreon stuff and there is really no other way of fixing this ... well, except spending money on it myself, but I'd rather not.

By the way: The one account I had access to when initially writing the Patreon extractor used attachments to have multiple images per post. So it does technically work, but only for attached files.

@biznizz
Copy link
Author

biznizz commented Aug 18, 2019

Okay, have tried it again. Previously, I just copied the "www patreon com/USERNAME/posts" link into the command prompt. You know, like when you just want to rip the whole Patreon? This time, I went to the individual post link, and this time, it did rip the whole multi-image!

So, it works if you use the direct link for a multi-image post in the command, but if you just use the generic "posts" link, then it'll scrape most everything, but won't be able to all pics in a multi-post. It's very strange.

@mikf
Copy link
Owner

mikf commented Aug 18, 2019

That's it! The metadata for a single post contains a list of all of its images, but the API result for a generic "posts" link didn't, and I didn't notice since I only used a single post for testing ...

I've updated the API query so it also includes an image list for each post and patreon com/USERNAME now also supports multiple images per post.

@biznizz
Copy link
Author

biznizz commented Aug 18, 2019

EDIT:

Downloaded the newest snapshot build and tried it out with generic "posts" link. Success! The ripper downloaded all of the pictures in a multi-image post without the need to use the direct link!

@biznizz biznizz closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants